-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to configure agent logging #83
base: master
Are you sure you want to change the base?
Conversation
6313324
to
8057c51
Compare
@bradrydzewski @tboerger Any feedback on this one? Cheers. |
Why don't you just define the logging driver on Docker daemon level? IMHO it doesn't make sense to define that per container. |
While one can certainly do this; the intent with the per container config options is to enable finer configuration. for example; If one does not want the Also, setting the behavior at the daemon level impacts the logging behavior of the containers which support pipeline |
8057c51
to
fa3dcac
Compare
@tboerger @bradrydzewski any additional thoughts on this one? |
2498c1a
to
d523688
Compare
d523688
to
6ec1a6f
Compare
6ec1a6f
to
0ade53b
Compare
Adds the ability to specify the logging driver and options for the runner (agent), gc, and watchtower containers.
0ade53b
to
1afc5e2
Compare
PR re-based against v1.8.1 and force-pushed |
Adds the ability to specify the logging driver and
options for the runner (agent), gc, and watchtower
containers.
Example config;
ref: https://docs.docker.com/config/containers/logging/configure/#supported-logging-drivers